GSoC’20 with OpenMRS | Coding Phase — Week 11
Progress — Week 11
This week was quite productive with the following progress:
- Worked on localisation of narratives.
- Created narrative templates for Patient, Medication and DispenseRequest resources.
- Worked on an issues related to narrative generation.
Tickets:
- [Draft PR created] FM2–280: Add support for localisation of narratives (link)
- [PR Under Review] FM2–297: Create default narratives for DiagnosticReport, Medication, Patient (link)
- [PR Under Review] FM2–295: Narrative generation failing for MedicationRequest resource (link)
- [PR Merged] FM2–281: Add checks for empty properties in narrative templates (link)
- [PR Merged] FM2–243: Fix test errors on Windows (link)
Pull Requests:
- [Draft PR under review] PR#278 (link) [for FM2–280]
- [Under Review] PR#288 (link) [for FM2–295]
- [Under Review] PR#287 (link) [for FM2–297]
Issues Faced:
The issues from last week got resolved. There was an issue with the messageSource
in tests (which would be autowired in the running instance) because of which messages were not getting fetched from the messages.properties
file.
Solution: In tests, we are now using ReloadableResourceBundleMessageSource
configured as per our needs.
The issue which came up this week is that the message source is not fetching the messages from the existing api/src/main/resources/messages.properties
file. Instead, it is fetching only from omod/src/main/resources/messages.properties
file.
Plan for Week-12
Since next week is the last week before the final evaluation period begins, the plan is to wrap everything up in the coming week. Also to resolve the issues and to get the PRs merged.